Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Deleting EventTypes when changing sink to a non-Broker kind #420

Merged
merged 26 commits into from
May 13, 2019

Conversation

nachocano
Copy link
Contributor

Proposed Changes

  • Changing event type reconciler to delete EventTypes of Sources whenever they point to a non-Broker sink.
  • Added UTs.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 13, 2019
@nachocano
Copy link
Contributor Author

/assign @n3wscott
last one Scott, I promise :)
This is the eventing-sources hopefully last registry fix :)

@nachocano
Copy link
Contributor Author

This should be merged before the 0.6 cut.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/gcppubsub/pkg/reconciler/gcppubsubsource.go 90.6% 90.5% -0.1
contrib/kafka/pkg/reconciler/kafkasource.go 89.2% 89.1% -0.2
pkg/reconciler/githubsource/githubsource.go 85.6% 85.5% -0.1

@vaikas
Copy link
Contributor

vaikas commented May 13, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@knative-prow-robot knative-prow-robot merged commit b6cdf39 into knative:master May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants