Upgrade Camel Sources to use Camel K 0.3.3 and add complex integrations #403
Conversation
knative-prow-robot
added
the
size/XXL
knative-prow-robot
added
the
needs-ok-to-test
|
Hi @nicolaferraro. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test
On Wed 8. May 2019 at 18:03, Knative Prow Robot ***@***.***> wrote:
@knative-prow-robot <https://github.com/knative-prow-robot> requested
your review on: #403
<#403> Upgrade Camel
Sources to use Camel K 0.3.3 and add complex integrations.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#403 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGPTW4Y7RPUMNQGJDMYLDPUL2ULANCNFSM4HLTCRPQ>
.
--
Sent from Gmail Mobile
|
knative-prow-robot
added
ok-to-test
|
@nicolaferraro pleae add release notes, using the release-notes format |
|
Should be ok now. |
| return p.Add(mgr, logger) | ||
| err := p.Add(mgr, logger) | ||
| if err != nil { | ||
| log.Println("Camel K cluster resources not installed correctly. Follow installation instructions at: https://github.com/apache/camel-k") |
There was a problem hiding this comment.
@nicolaferraro could this also be used to prevent the CrashLoop ? if the actual Camel-K bits are not yet there?
|
@matzew I've added a check to avoid the crashloop and keep waiting for Camel K resources instead. That should make installation easier. |
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, nicolaferraro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Proposed Changes
This PR upgrades Camel sources to use Camel K 0.3.3 and adds the additional type
integrationto the kind of supported sources so that users are now able to use a full camel k integration as knative sources (example included of a source that polls a remote URL to get data).Other notable changes:
Release Note