Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

k8s resources spec changes #381

Merged
merged 2 commits into from
May 13, 2019
Merged

k8s resources spec changes #381

merged 2 commits into from
May 13, 2019

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 30, 2019

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 30, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2019
@matzew
Copy link
Member Author

matzew commented Apr 30, 2019

/test pull-knative-eventing-sources-integration-tests

vaikas
vaikas reviewed May 1, 2019
View reviewed changes
config/500-controller.yaml Outdated
requests:
cpu: 100m
memory: 20Mi
memory: 1000Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 100Mi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaikas-google it's the same as the sources-controller has in eventing repo - happy to change, though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n3wscott @vaikas-google happy to change to 100Mi - if so... than I will also do the same for sources_controller in "eventing" repo (b/c that's where I did borrow this value from)

thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000Mi seems like a typo.

@matzew
Copy link
Member Author

matzew commented May 9, 2019 via email

@matzew
Copy link
Member Author

matzew commented May 13, 2019

@n3wscott I've updated the fix, and corrected the typo

@matzew
Copy link
Member Author

matzew commented May 13, 2019

@vaikas-google @n3wscott would be good to have this in for the 0.6.0 release ?

evankanderson
evankanderson reviewed May 13, 2019
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly terrified of what could cause the GitHub receive adapter to need 1GB of RAM, but the default request of 100MB seems reasonable.

/lgtm
/ok-to-test
/approve

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels May 13, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@knative-prow-robot knative-prow-robot merged commit fd829bc into knative:master May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evankanderson evankanderson evankanderson left review comments

@vaikas vaikas vaikas left review comments

@n3wscott n3wscott n3wscott left review comments

Assignees

@evankanderson evankanderson

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matzew @knative-prow-robot @evankanderson @vaikas @n3wscott @googlebot