This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
use cloudevent alias pkg #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
n3wscott
reviewed
Apr 17, 2019
pkg/kncloudevents/good_client.go
Outdated
| @@ -1,26 +1,29 @@ | |||
| package kncloudevents | |||
|
|
|||
| import ( | |||
| "github.com/cloudevents/sdk-go" | |||
| "github.com/cloudevents/sdk-go/pkg/cloudevents/client" | |||
| "github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http" | |||
| ) | |||
|
|
|||
| func NewDefaultClient(target ...string) (client.Client, error) { | |||
There was a problem hiding this comment.
This client too in the sig
| @@ -1,26 +1,29 @@ | |||
| package kncloudevents | |||
|
|
|||
| import ( | |||
| "github.com/cloudevents/sdk-go" | |||
| "github.com/cloudevents/sdk-go/pkg/cloudevents/client" | |||
| "github.com/cloudevents/sdk-go/pkg/cloudevents/transport/http" | |||
There was a problem hiding this comment.
@n3wscott Option is still in http,
pkg/kncloudevents/good_client.go
Outdated
| // Use the transport to make a new CloudEvents client. | ||
| c, err := client.New(t, | ||
| c, err := cloudevents.NewClient(t, | ||
| client.WithUUIDs(), |
There was a problem hiding this comment.
This can come from cloudevents too
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
silvagiiu
referenced
this pull request
May 18, 2019
* Adding smaller set of owners for sources. * adding base authors to sources. * Adding github stuff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title
/cc @n3wscott