This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Missing RBAC rules for finalizers #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
|
/test pull-knative-eventing-sources-integration-tests |
n3wscott
reviewed
Apr 15, 2019
config/201-clusterrole.yaml
Outdated
| - sources.eventing.knative.dev | ||
| resources: | ||
| - '*/finalizers' | ||
| verbs: |
n3wscott
reviewed
Apr 15, 2019
config/201-clusterrole.yaml
Outdated
| - apiGroups: | ||
| - sources.eventing.knative.dev | ||
| resources: | ||
| - '*/finalizers' |
There was a problem hiding this comment.
there is not another example of * in all of knative, I think we should be explicit.
knative-prow-robot
added
size/S
|
@n3wscott I am explicit now :-) |
n3wscott
reviewed
Apr 15, 2019
config/201-clusterrole.yaml
Outdated
| - cronjobsources/finalizers | ||
| - githubsources/finalizers | ||
| - kuberneteseventsources/finalizers | ||
| verbs: &everything |
There was a problem hiding this comment.
change this to verbs: *everything
you are redefining the magic everything yaml tag
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on OpenShift, which has fairly restrictive RBAC out of the
box, the sources are missing a RBAC rules that
requires permissions on the different *sources/finalizers resource.
See also #318
/cc @evankanderson