Event Registry - Sources Part 1

[nachocano]

First part of sources for the Registry feature request: knative/eventing#929

Important

• This still doesn't address the changes of CloudEvents source and subject attributes. There is still some debate of what should be put in each. This PR just sets the framework necessary to easily set those attributes in a subsequent PR.
• Changes to Sources CRD to include description and schema attributes are not there yet.

Proposed Changes

• Creating EventTypes in the following source controllers, from which we know (at least some of) the events they can produce:
  • GitHub
  • AWS SQS
  • GCPPubSub
  • Kafka
• Only creating the EventTypes for Broker sinks.
• Created a common EventType "reconciler" helper to avoid duplicating code across the source controllers.
• Adding dependency of the eventing repo (and updating pkg)

Release Note

On installing a source CO (GitHub, AWS SQS, GCPPubSub, or Kafka), its EventTypes will be added to the Registry.

[grantr]

Still working through, but here are some more comments!

[grantr]

Got through everything!

[nachocano]

Got through everything!

Thanks a lot @grantr . Your review was very helpful! Will let you know when is ready for a second pass

[nachocano]

Tested gcppubsub, kafka, and github... Seems to be working fine. Cannot easily test aws sqs.
Still need to update source and subject values (mainly in github adapter), will be done in the following PR.

NAME                                          TYPE                                     SOURCE                                                          SCHEMA   BROKER    DESCRIPTION   READY   REASON
dev.knative.kafka.event-cjvcr                 dev.knative.kafka.event                  topic2                                                                   default                 True    
dev.knative.kafka.event-tdt48                 dev.knative.kafka.event                  knative-demo-topic                                                       default                 True    
dev.knative.source.github.pullrequest-pkb8c   dev.knative.source.github.pull_request   nachocano/eventing                                                       default                 True    
dev.knative.source.github.push-vmbl2          dev.knative.source.github.push           nachocano/eventing                                                       default                 True    
google.pubsub.topic.publish-hrxhh             google.pubsub.topic.publish              //pubsub.googleapis.com/knative-project-228222/topics/testing            default                 True    

[nachocano]

@grantr @vaikas-google @n3wscott
this is ready for a second pass. There are a couple of separate follow up issues that I can take care later on, but the basic functionality herein seems to be working (see kubectl get eventtypes output above). The main one is a refactoring of the eventtype reconciler proposed by Grant, which makes a lot of sense. I guess I didn't get it right away.

The next PR should contain the changes to source and subject.

[vaikas]

/approve

[nachocano]

Made a small refactor to make it easier for the bigger one later on. Added the eventtype package again, inside reconciler, with its own resources dir. The guys were right :)

[nachocano]

@grantr @vaikas-google @n3wscott friendly ping to lgtm (or keep on adding comments) so that I can continue with the follow ups.

[vaikas]

I already approved, sorry. should've said explicitly, letting @grantr @n3wscott take a look since they had some suggestiongs.

[grantr]

Just the one change left from me (remove Raw) then 👍

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grantr,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nachocano]

Just the one change left from me (remove Raw) then

Done!

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-sources-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
contrib/gcppubsub/pkg/apis/sources/v1alpha1/gcp_pubsub_types.go	100.0%	93.8%	-6.2
contrib/gcppubsub/pkg/reconciler/gcppubsubsource.go	88.7%	90.0%	1.3
contrib/kafka/pkg/reconciler/kafkasource.go	86.0%	89.2%	3.2
pkg/adapter/github/adapter.go	97.9%	97.9%	0.0
pkg/apis/sources/v1alpha1/githubsource_types.go	100.0%	92.9%	-7.1

[grantr]

/lgtm