Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Bug revise of MutatingWebhookName mismatching #712

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Bug revise of MutatingWebhookName mismatching #712

merged 1 commit into from
Nov 19, 2019

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 7, 2019

Fixes #702

Proposed Changes

Release Note

fixes broken webhook (see #702) 

Thanks @kaidotdev for filing

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Nov 7, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@matzew
Copy link
Member Author

matzew commented Nov 7, 2019

/test pull-knative-eventing-contrib-integration-tests

@matzew
Copy link
Member Author

matzew commented Nov 7, 2019

@googlebot I consent

2 similar comments
@matzew
Copy link
Member Author

matzew commented Nov 7, 2019

@googlebot I consent

@matzew
Copy link
Member Author

matzew commented Nov 8, 2019

@googlebot I consent

@matzew
Copy link
Member Author

matzew commented Nov 8, 2019

/test pull-knative-eventing-contrib-integration-tests

@matzew
Copy link
Member Author

matzew commented Nov 8, 2019

@kaidotdev can u comment here with:

@googlebot I consent

@ghost
Copy link

ghost commented Nov 8, 2019

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 8, 2019
@matzew
Copy link
Member Author

matzew commented Nov 14, 2019

/close

@knative-prow-robot
Copy link
Contributor

@matzew: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member Author

matzew commented Nov 14, 2019

/reopen

@knative-prow-robot
Copy link
Contributor

@matzew: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chizhg
Copy link
Member

chizhg commented Nov 18, 2019

There is some change for the tests in the release-0.10 branch, please update your local release-0.10 and merge into this PR.

@lberk
Copy link
Member

lberk commented Nov 19, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@knative-prow-robot knative-prow-robot merged commit cfa9e6e into knative:release-0.10 Nov 19, 2019
@lberk lberk mentioned this pull request May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants