Kafka src desitation #688
Kafka src desitation #688
Conversation
knative-prow-robot
added
the
size/L
knative-prow-robot
added
the
approved
| @@ -75,7 +76,8 @@ type Reconciler struct { | |||
| receiveAdapterImage string | |||
| eventTypeLister eventinglisters.EventTypeLister | |||
| kafkaLister listers.KafkaSourceLister | |||
| sinkReconciler *duck.SinkReconciler | |||
| sinkResolver *resolver.URIResolver | |||
| sinkReconciler *duck.SinkReconciler | |||
There was a problem hiding this comment.
I don't think this should be there anymore? sinkResolver should be the only thing you need?
|
/lgtm |
|
The following is the coverage report on the affected files.
|
| minLength: 1 | ||
| uri: | ||
| type: string | ||
| description: "the target URI. If ref is provided, this must be relative URI reference." |
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, @grantr will PR the same for couch as well - after these are in, ok ?
There was a problem hiding this comment.
@lionelvillard I think we should also change anyOf to oneOf
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, matzew, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
Release Note