-
Notifications
You must be signed in to change notification settings - Fork 225
Conversation
Eliminates the need to manually update release tags for each release. Copied from serving.
ConfigMaps are expected to be updated by users, so they don't get release tags.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v0.8.0 |
@@ -32,11 +32,20 @@ COMPONENTS=( | |||
readonly COMPONENTS | |||
|
|||
function build_release() { | |||
# Update release labels if this is a tagged release | |||
if [[ -n "${TAG}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who sets this TAG env variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's set by the release helpers when both --tag-release
and --version
are set.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Companion to knative/eventing#1644.
Proposed Changes