This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Backport knative pgk with addressable fix and unit test #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* migrate to knative.dev/pkg * fix tests.
* Porting sink change over from 'eventing core' * updates
* Start to use GetURL on Addressable instead of assuming Hostname. * Remove trailing slash.
knative-prow-robot
added
the
size/XXL
knative-prow-robot
requested review from
bbrowning,
grantr,
Harwayne,
nbarthwal and
rootfs
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, Harwayne, matzew, rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing critical bug regarding
addressableand make contrib work w/ servingv1beta1Proposed Changes
Port a few PRs to 0.7 release branch, to get contrib working w/ serving
v1beta1:Release Note