This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Add kafkaSource saslType, e2e tests for auth (tls and sasl512) #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventing-kafka#237 backport * Add kafkasource SASL Type * Add unit tests for NewConfig in source client * wip, Add tests, lifecycle, e2e test * Fix v1alpha1 conversion, tests * Refactor tests * Change kafkabinding sasltype json to 'Type' * Rework test call structure
knative-prow-robot
added
size/XL
|
action failures seem to be unrelated to the actual PR |
|
The following is the coverage report on the affected files.
|
matzew
reviewed
Nov 30, 2020
| @@ -192,13 +192,13 @@ func testKafkaSource(t *testing.T, name string, version string, messageKey strin | |||
| defer testlib.TearDown(client) | |||
|
|
|||
| if auth.SASLEnabled { | |||
| _, err := utils.CopySecret(client.Kube.CoreV1(), "knative-eventing", kafkaSASLSecret, client.Namespace, "default") | |||
| _, err := utils.CopySecret(client.Kube.Kube.CoreV1(), "knative-eventing", kafkaSASLSecret, client.Namespace, "default") | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lberk, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knative-extensions/eventing-kafka#237 backport
Add kafkasource SASL Type
Add unit tests for NewConfig in source client
wip, Add tests, lifecycle, e2e test
Fix v1alpha1 conversion, tests
Refactor tests
Change kafkabinding sasltype json to 'Type'
Rework test call structure