Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Fix the apiVersion used in the GitHubSource filters. #1007

Closed
wants to merge 1 commit into from
Closed

Fix the apiVersion used in the GitHubSource filters. #1007

wants to merge 1 commit into from

Conversation

mattmoor
Copy link
Member

  • 🐛 This fixes the filter used with the OwnerReferences on all of the GitHubSource informers (and possibly more in other contrib sources).

Fixes: #997

@mattmoor
Fix the apiVersion used in the GitHubSource filters.
e1607d6 
This fixes the filter used with the OwnerReferences on all of the GitHubSource informers (and possibly more in other contrib sources).

Fixes: knative#997
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattmoor
To complete the pull request process, please assign grantr
You can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

It looks like Prometheus and CouchDb have the same problem (from a superficial inspection).

@lionelvillard
Copy link
Member

/test pull-knative-eventing-contrib-integration-tests

@lionelvillard
Copy link
Member

is this file needed? I actually wonder do we need anything under pkg? @vaikas @n3wscott @grantr @matzew ?

@mattmoor
Copy link
Member Author

@lionelvillard I was going with a minimal fix for cherry-picking, but I agree that we should probably eliminate these subtrees. I'm happy to follow up with that, if we all agree. I'll start on that now to see if there are any landmines.

mattmoor added a commit to mattmoor/eventing-contrib that referenced this pull request Mar 10, 2020
@mattmoor
Drop pkg/apis in eventing-contrib.
e4a5883 
This is a more complete fix for knative#1007 (which is intended for cherry-picking), which pushes the shared functionality into individual packages.
@mattmoor mattmoor mentioned this pull request Mar 10, 2020
Merged
mattmoor added a commit to mattmoor/eventing-contrib that referenced this pull request Mar 10, 2020
@mattmoor
Drop pkg/apis in eventing-contrib.
aa37290 
This is a more complete fix for knative#1007 (which is intended for cherry-picking), which pushes the shared functionality into individual packages.
mattmoor added a commit to mattmoor/eventing-contrib that referenced this pull request Mar 10, 2020
@mattmoor
Drop pkg/apis in eventing-contrib.
641f96d 
This is a more complete fix for knative#1007 (which is intended for cherry-picking), which pushes the shared functionality into individual packages.
@mattmoor
Copy link
Member Author

Going to remake this against release-0.13

@mattmoor mattmoor closed this Mar 10, 2020
@mattmoor mattmoor mentioned this pull request Mar 10, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Mar 10, 2020
@mattmoor
Drop pkg/apis in eventing-contrib. (#1009)
641dc4e 
* Drop pkg/apis in eventing-contrib.

This is a more complete fix for #1007 (which is intended for cherry-picking), which pushes the shared functionality into individual packages.

* Run codegen
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@grantr grantr

@n3wscott n3wscott

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github source doesn't seem to create webhook until kicked
6 participants
@mattmoor @knative-prow-robot @lionelvillard @grantr @googlebot @n3wscott