Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security audit: Typos and wrong link #5791

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Security audit: Typos and wrong link #5791

merged 1 commit into from
Dec 5, 2023

Conversation

davidhadas
Copy link
Contributor

Fix wrong link + another nit

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit 0f051b0
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/656f5b485162230008b24d1c
😎 Deploy Preview https://deploy-preview-5791--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2023
@davidhadas
Copy link
Contributor Author

davidhadas commented Dec 5, 2023 •
edited
Loading

/cc @evankanderson

evankanderson
evankanderson reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apparently I'm not good at copy-paste. 🤦

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidhadas,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1f2e64b into main Dec 5, 2023
19 checks passed
@dprotaso dprotaso deleted the dh-001 branch July 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhadas @evankanderson