Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes all references of kn quickstart to kn-quickstart #4262

Closed
wants to merge 1 commit into from

Conversation

JeffNeff
Copy link
Contributor

Fixes #4261

Proposed Changes

  • Changes references of kn quickstart to kn-quickstart in both blog/releases/announcing-knative-v0-25-release.md and docs/snippets/quickstart-install.md

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 19, 2021
@netlify
Copy link

netlify bot commented Sep 19, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 1373d5a

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61476c8ab3d62a0008eae14f

😎 Browse the preview: https://deploy-preview-4262--knative.netlify.app

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JeffNeff
To complete the pull request process, please assign pmorie after the PR has been reviewed.
You can assign the PR to them by writing /assign @pmorie in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2021
@knative-prow-robot
Copy link
Contributor

Hi @JeffNeff. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@psschwei
Copy link
Contributor

/hold

I think the user experience we were aiming for was using the plugin as part of the kn client (i.e. kn quickstart, not kn-quickstart). @omerbensaadon @csantanapr please confirm I'm remembering things right.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@csantanapr
Copy link
Member

Correct @psschwei

@snneji
Copy link
Contributor

snneji commented Oct 4, 2021

@psschwei do the docs need to change? I'm wondering what we should do with this PR and the associated issue. If no changes are necessary will they need to be closed?

@psschwei
Copy link
Contributor

psschwei commented Oct 5, 2021

I don't think a doc change is needed (kn quickstart without a hyphen is what we want), so this issue/PR can be closed.

@snneji
Copy link
Contributor

snneji commented Oct 6, 2021

Thanks for the PR @JeffNeff. I'm going to close it because the issue was resolved without needed docs changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Knative Quickstart
5 participants