-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes all references of kn quickstart
to kn-quickstart
#4262
Conversation
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: 1373d5a 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61476c8ab3d62a0008eae14f 😎 Browse the preview: https://deploy-preview-4262--knative.netlify.app |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JeffNeff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JeffNeff. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold I think the user experience we were aiming for was using the plugin as part of the |
Correct @psschwei |
@psschwei do the docs need to change? I'm wondering what we should do with this PR and the associated issue. If no changes are necessary will they need to be closed? |
I don't think a doc change is needed ( |
Thanks for the PR @JeffNeff. I'm going to close it because the issue was resolved without needed docs changes. |
Fixes #4261
Proposed Changes
kn quickstart
tokn-quickstart
in bothblog/releases/announcing-knative-v0-25-release.md
anddocs/snippets/quickstart-install.md