Update Knative Serving GCS bucket#234
Merged
google-prow-robot merged 5 commits intoknative:masterfrom Jul 24, 2018
adrcunha:separate-releases
Merged
Update Knative Serving GCS bucket#234google-prow-robot merged 5 commits intoknative:masterfrom adrcunha:separate-releases
google-prow-robot merged 5 commits intoknative:masterfrom
adrcunha:separate-releases
Conversation
Knative Serving release was moved to its own directory in knative/serving#1654.
google-prow-robot
added
the
size/M
Contributor
Author
|
/hold This must be merged after knative/serving#1654 is merged and a new release is cut. |
google-prow-robot
added
the
do-not-merge/hold
grantr
reviewed
Jul 23, 2018
install/Knative-with-Gardener.md
Outdated
| kubectl create configmap istio-chart-080 --from-file=istio.yaml | ||
|
|
||
| curl https://storage.googleapis.com/knative-releases/latest/release.yaml -o knative.yaml | ||
| curl https://storage.googleapis.com/knative-releases/serving/latest/release.yaml -o knative.yaml |
Contributor
There was a problem hiding this comment.
Should the -o knative.yaml change to serving.yaml or release.yaml?
Member
|
/assign @rgregg I think we should use the yamls attached to the |
Contributor
Author
|
/hold cancel |
google-prow-robot
removed
the
do-not-merge/hold
Member
|
/approve We can update these again later |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, grantr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knative Serving release was moved to its own directory in knative/serving#1654.