Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document progressDeadline annotation on per revision basis #5767

Closed
andrew-delph opened this issue Nov 23, 2023 · 3 comments · Fixed by #5773
Closed

Document progressDeadline annotation on per revision basis #5767

andrew-delph opened this issue Nov 23, 2023 · 3 comments · Fixed by #5773
Assignees
Labels
help wanted kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@andrew-delph
Copy link

andrew-delph commented Nov 23, 2023

Documentation request

The feature to set progressDeadline on a per-revision basis has been recently introduced. Previously, this setting was only configurable on a global level. However, there appears to be a lack of documentation regarding this new capability.

Current documentation for global progress deadline can found here.

Possibly documentation can be similar to target RPS: https://knative.dev/docs/serving/autoscaling/rps-target/#configuring-the-requests-per-second-rps-target

here is an example of the annotation:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: hello
spec:
  template:
    metadata:
      annotations:
         serving.knative.dev/progress-deadline: "45s" 
    spec:
      containers:
        - image: ghcr.io/knative/helloworld-go:latest
          ports:
            - containerPort: 8080
          env:
            - name: TARGET
              value: "World"

@andrew-delph andrew-delph changed the title Missing documentation - progressDeadline annotation on per revision basis Documentation request - progressDeadline annotation on per revision basis Nov 23, 2023
@ReToCode
Copy link
Member

/cc @skonto

@ReToCode ReToCode added kind/good-first-issue Denotes an issue ready for a new contributor. help wanted labels Nov 24, 2023
@ReToCode ReToCode changed the title Documentation request - progressDeadline annotation on per revision basis Document progressDeadline annotation on per revision basis Nov 24, 2023
@UtkarshUmre
Copy link

I would like to work on this issue. Can you assign this to me?

@navinag1989
Copy link
Contributor

/assign

navinag1989 pushed a commit to navinag1989/docs that referenced this issue Nov 25, 2023
Added documentation to configure progressDeadline on per-revision basis.
navinag1989 added a commit to navinag1989/docs that referenced this issue Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment