Add changes for --scale-init support #990

hemanrnjn · 2020-08-25T11:34:57Z

Description

Now that we have support for defining the initial scale for a service, implementing --scale-init with kn as a top-level option instead of just as an annotation.

Changes

Add support for --scale-init option

Reference

Fixes #959

knative-prow-robot

@hemanrnjn: 0 warnings.

In response to this:

Description

Changes

Add support for --scale-init option

Reference

Fixes #959

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot · 2020-08-25T11:35:10Z

Hi @hemanrnjn. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhuss · 2020-08-25T12:46:49Z

/ok-to-test

hemanrnjn · 2020-08-25T12:54:05Z

@rhuss I'm adding test cases so till then I'll put this PR in WIP.

maximilien

@hemanrnjn thanks for the contribution. Are you ready for some feedback or would you rather we wait for when you remove the WIP tag?

hemanrnjn · 2020-08-26T08:20:12Z

@hemanrnjn thanks for the contribution. Are you ready for some feedback or would you rather we wait for when you remove the WIP tag?

Sure. Why not! I'd also implement those feedback while the PR is in WIP.

maximilien

Left some initial. Happy to do another round when addressed and more tests added (unit and e2e).
Thanks for contribution again.

docs/cmd/kn_service_update.md

pkg/kn/commands/service/configuration_edit_flags.go

rhuss

Thanks a lot for this PR ! Looks good to me, with some minor suggestions (see below)

docs/cmd/kn_service_update.md

pkg/kn/commands/service/configuration_edit_flags.go

navidshaikh · 2020-09-02T07:57:59Z

Just out of curiosity I wonder how this works for an "update". Is it that the current number of replicas is changed to this number when the update is triggered ?

@rhuss : IIUC, yes, this would scale the number of replicas to match given init-scale and mark the revision ready, and then it'll ignore this value (for eg in no-traffic scale to zero case). This property applies to per revision, so setting this for to-be-created revision in an update should be a valid use case.

hemanrnjn · 2020-09-07T07:56:18Z

/retest

hemanrnjn · 2020-09-07T09:00:22Z

/retest

hemanrnjn · 2020-09-07T12:06:55Z

/retest

hemanrnjn · 2020-09-08T07:43:02Z

/retest

rhuss · 2020-09-08T08:43:05Z

/retest

hemanrnjn · 2020-09-08T11:36:16Z

@navidshaikh and @rhuss I have made all the changes and added all test cases. Please take one final look at it, if they look fine to you guys too?

pkg/kn/commands/service/configuration_edit_flags.go

knative-metrics-robot · 2020-09-14T11:31:24Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	83.0%	83.2%	0.2

hemanrnjn · 2020-09-14T12:03:28Z

/retest

navidshaikh

/lgtm
/approve

thanks @hemanrnjn ! The changelog entry is missing but you can add that in a separate PR.

knative-prow-robot · 2020-09-15T09:51:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hemanrnjn, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add changes for --scale-init support * Added test cases * Add test case in e2e tests * minor fix * Test case failure fix * Incorporated review comments * Add service update test cases * Incorporate review comments

Add changes for --scale-init support

41af47d

knative-prow-robot requested review from evankanderson and navidshaikh August 25, 2020 11:35

knative-prow-robot reviewed Aug 25, 2020

View reviewed changes

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020

knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2020

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2020

hemanrnjn changed the title ~~Add changes for --scale-init support~~ WIP: Add changes for --scale-init support Aug 25, 2020

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020

Added test cases

b0347fa

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2020

maximilien reviewed Aug 25, 2020

View reviewed changes

hemanrnjn added 3 commits August 26, 2020 23:22

Add test case in e2e tests

f3c66da

minor fix

2f4ab36

Test case failure fix

945163c

hemanrnjn changed the title ~~WIP: Add changes for --scale-init support~~ Add changes for --scale-init support Aug 26, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2020

maximilien suggested changes Aug 27, 2020

View reviewed changes

Incorporated review comments

7d4021b

rhuss requested changes Sep 1, 2020

View reviewed changes

hemanrnjn changed the title ~~Add changes for --scale-init support~~ WIP: Add changes for --scale-init support Sep 1, 2020

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2020

Add service update test cases

6fec4df

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2020

hemanrnjn changed the title ~~WIP: Add changes for --scale-init support~~ Add changes for --scale-init support Sep 11, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2020

navidshaikh requested changes Sep 12, 2020

View reviewed changes

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2020

hemanrnjn added 2 commits September 14, 2020 16:46

Incorporate review comments

16ce1d3

Resolve merge conflicts

8c770c6

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2020

hemanrnjn requested review from navidshaikh, maximilien, rhuss and knative-prow-robot September 15, 2020 07:45

navidshaikh approved these changes Sep 15, 2020

View reviewed changes

knative-prow-robot assigned navidshaikh Sep 15, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020

knative-prow-robot merged commit 6c7fc7c into knative:master Sep 15, 2020

hemanrnjn mentioned this pull request Sep 15, 2020

CHANGELOG entry for PR #990 #1012

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add changes for --scale-init support #990

Add changes for --scale-init support #990

hemanrnjn commented Aug 25, 2020 •

edited

Loading

knative-prow-robot left a comment

knative-prow-robot commented Aug 25, 2020

rhuss commented Aug 25, 2020

hemanrnjn commented Aug 25, 2020

maximilien left a comment

hemanrnjn commented Aug 26, 2020

maximilien left a comment

rhuss left a comment

navidshaikh commented Sep 2, 2020 •

edited

Loading

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 8, 2020

rhuss commented Sep 8, 2020

hemanrnjn commented Sep 8, 2020

knative-metrics-robot commented Sep 14, 2020

hemanrnjn commented Sep 14, 2020

navidshaikh left a comment

knative-prow-robot commented Sep 15, 2020

Add changes for --scale-init support #990

Add changes for --scale-init support #990

Conversation

hemanrnjn commented Aug 25, 2020 • edited Loading

Description

Changes

Reference

knative-prow-robot left a comment

Choose a reason for hiding this comment

Description

Changes

Reference

knative-prow-robot commented Aug 25, 2020

rhuss commented Aug 25, 2020

hemanrnjn commented Aug 25, 2020

maximilien left a comment

Choose a reason for hiding this comment

hemanrnjn commented Aug 26, 2020

maximilien left a comment

Choose a reason for hiding this comment

rhuss left a comment

Choose a reason for hiding this comment

navidshaikh commented Sep 2, 2020 • edited Loading

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 7, 2020

hemanrnjn commented Sep 8, 2020

rhuss commented Sep 8, 2020

hemanrnjn commented Sep 8, 2020

knative-metrics-robot commented Sep 14, 2020

hemanrnjn commented Sep 14, 2020

navidshaikh left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Sep 15, 2020

hemanrnjn commented Aug 25, 2020 •

edited

Loading

navidshaikh commented Sep 2, 2020 •

edited

Loading