Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds info message after service create and delete operations #95

Merged
merged 2 commits into from
May 14, 2019
Merged

Adds info message after service create and delete operations #95

merged 2 commits into from
May 14, 2019

Conversation

navidshaikh
Copy link
Collaborator

Fixes #87

@knative-prow-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2019
@navidshaikh
Adds info message after service create operation
cf56084 
 Fixes knative#87

 Aligns the service delete info message with service create too.
@cppforlife
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2019
@rhuss rhuss mentioned this pull request May 11, 2019
Closed
@navidshaikh
Updates per review comments
0e9a5be 
 Adds newline after std imports
 Line breaks at proper operator
@navidshaikh navidshaikh changed the title Adds info message after service create operation Adds info message after service create and delete operation May 13, 2019
@navidshaikh navidshaikh changed the title Adds info message after service create and delete operation Adds info message after service create and delete operations May 13, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service_create.go 74.1% 75.0% 0.9

@navidshaikh navidshaikh mentioned this pull request May 13, 2019
Closed
@cppforlife
Copy link

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@knative-prow-robot knative-prow-robot merged commit 5b8b9d5 into knative:master May 14, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
6d7573f 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
7332ec5 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
a3e9925 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
@navidshaikh navidshaikh deleted the fix-87 branch November 18, 2019 12:38
dsimansk added a commit to dsimansk/client that referenced this pull request Mar 2, 2023
@dsimansk
[release-v1.7] Add kn-plugin-workflow v0.25.0 (knative#95)
05fce8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@cppforlife cppforlife

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a message on stdout after service create
4 participants
@navidshaikh @knative-prow-robot @cppforlife @knative-metrics-robot