feat: Add plugin listing to "kn --help" #929
Conversation
This works on all levels. Test needs to be expanded still. Fixes knative#266
knative-prow-robot
added
approved
| } | ||
|
|
||
| commandParts := extractPluginCommandFromFileName(name) | ||
| if len(commandParts) != len(commandGroupParts)+1 { |
There was a problem hiding this comment.
Can we get some English comments for these conditions... typically not for comments but when conditions are not obvious...
|
The following is the coverage report on the affected files.
|
|
/retest |
|
@navidshaikh @maximilien tests are green, I also slurped in #910 so that we can get quicker to the release. |
|
There is probably still someplace for improvement (e.g. how to get to the description of a plugin, for now just the path is printed). But maybe let's leave that for the next release. |
There was a problem hiding this comment.
Looks good to me. So let's get this in
/lgtm
➜ client git:(pr/plugin-help) ✗ ./kn -h
kn is the command line interface for managing Knative Serving and Eventing resources
Find more information about Knative at: https://knative.dev
Serving Commands:
service Manage Knative services
revision Manage service revisions
route List and describe service routes
Eventing Commands:
source Manage event sources
broker Manage message broker
trigger Manage event triggers
Other Commands:
plugin Manage kn plugins
completion Output shell completion code
version Show the version of this client
Plugins:
curl /Users/maximilien/.config/kn/plugins/kn-curl
source-github /Users/maximilien/.config/kn/plugins/kn-source_github
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This works on all levels. Test needs to be expanded still.
Fixes #266
Fixes #904