Add --requests and --limits resource flags

[navidshaikh]

Description

• Add --requests and --limits flags for service create and update
• Deprecate --requests-cpu, --requests-memory, --limits-cpu and --limits-memory flags

Changes

• Add service create example for using memory, CPU, GPU resources
• Add error message if new and deprecated, requests and limits flags are used together
• Add warning message if deprecated flags are used
• Add unit and e2e tests, update existing unit tests

Reference

Fixes #490

/lint

Example:

GPU resource

$ kn service create hello-gpu-2 --image docker.io/mvinkler/hellocuda-go --limits nvidia.com/gpu=1
Creating service 'hello-gpu-2' in namespace 'default':
  5.175s Configuration "hello-gpu-2" is waiting for a Revision to become ready.
  5.299s Ingress has not yet been reconciled.
  5.635s Ready to serve.
Service 'hello-gpu-2' created to latest revision 'hello-gpu-2-qrcqg-1' is available at URL:
http://hello-gpu-2-default.OOO

$ curl http://hello-gpu-2-default.OOO
cuda-vector-add output:  [Vector addition of 50000 elements]
Copy input data from the host memory to the CUDA device
CUDA kernel launch with 196 blocks of 256 threads
Copy output data from the CUDA device to the host memory
Test PASSED
Done

[knative-prow-robot]

@navidshaikh: 1 warning.

In response to this:

Description

• Add --requests and --limits flags for service create and update
• Deprecate --requests-cpu, --requests-memory, --limits-cpu and --limits-memory flags

Changes

• Add service create example for using memory, CPU, GPU resources
• Add error message if new and deprecated, requests and limits flags are used together
• Add warning message if deprecated flags are used
• Add unit and e2e tests, update existing unit tests

Reference

Fixes #490

/lint

Example:

GPU resource

$ kn service create hello-gpu-2 --image docker.io/mvinkler/hellocuda-go --limits nvidia.com/gpu=1
Creating service 'hello-gpu-2' in namespace 'default':
 5.175s Configuration "hello-gpu-2" is waiting for a Revision to become ready.
 5.299s Ingress has not yet been reconciled.
 5.635s Ready to serve.
Service 'hello-gpu-2' created to latest revision 'hello-gpu-2-qrcqg-1' is available at URL:
http://hello-gpu-2-default.OOO

$ curl http://hello-gpu-2-default.OOO
cuda-vector-add output:  [Vector addition of 50000 elements]
Copy input data from the host memory to the CUDA device
CUDA kernel launch with 196 blocks of 256 threads
Copy output data from the CUDA device to the host memory
Test PASSED
Done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lgtm-com]

This pull request introduces 1 alert when merging f1a41f8 into 4ba1cca - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[navidshaikh]

/lint

[knative-prow-robot]

@navidshaikh: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maximilien]

See comments.

[rhuss]

/retest

[rhuss]

looks good from my side.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	84.7%	84.6%	-0.1
pkg/kn/flags/resources.go	Do not exist	100.0%
pkg/serving/config_changes.go	79.6%	76.7%	-2.9

[rhuss]

thanks !

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment