Adds human-friendly table printing for resource listing #85
Conversation
knative-prow-robot
added
size/L
|
Hi @navidshaikh. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
|
@navidshaikh i dont see any command using this printers, or did i miss it? |
@cppforlife : I'll raise separate PRs for commands using this printer. |
|
@cppforlife Here is the new one #90 rebased onto this PR. |
All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers
As its updated after running hack/verify-codegen.sh
Lets start with bare minimum printer
and references the original implementation file link. Removes pkg/printers/printers.go
navidshaikh
force-pushed
the
human-printing
branch
from
b9298a4
to
06f8cd0
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
knative-prow-robot
added
the
approved
|
/approve |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Adds human-friendly printer All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers * Updates the vendor/modules.txt As its updated after running hack/verify-codegen.sh * Removes WithKind and WithNamespace printing options Lets start with bare minimum printer * Adds licenses and references the original implementation file link. Removes pkg/printers/printers.go * Removes unused imports
* Adds human-friendly printer All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers * Updates the vendor/modules.txt As its updated after running hack/verify-codegen.sh * Removes WithKind and WithNamespace printing options Lets start with bare minimum printer * Adds licenses and references the original implementation file link. Removes pkg/printers/printers.go * Removes unused imports
* Adds human-friendly printer All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers * Updates the vendor/modules.txt As its updated after running hack/verify-codegen.sh * Removes WithKind and WithNamespace printing options Lets start with bare minimum printer * Adds licenses and references the original implementation file link. Removes pkg/printers/printers.go * Removes unused imports
Also dump the last checked status of the pods on error, so it's easy to figure out what was wrong.
Fixes #84
All the credits goes to https://github.com/kubernetes/kubernetes/tree/master/pkg/printers