Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): Create next namespace for e2e if one exists #835

Merged
merged 5 commits into from
May 14, 2020
Merged

fix(e2e): Create next namespace for e2e if one exists #835

merged 5 commits into from
May 14, 2020

Conversation

navidshaikh
Copy link
Collaborator

Description

  • If a namespace (kne2etestsN) is being created to run e2e tests and it exists, e2e execution fails. This patch tries creating the next namespace (kne2etestsN+1) if earlier exists, retries cap at 20.
  • Tags plugins tests to run into serving or eventing scope but only in e2e scope.

@navidshaikh
fix(e2e): Create next namespace if one exists
7c60100 
 Do not error out if the namespace to run e2e into exists, try creating
 next one in row. Retry at 20 next namespaces, before erroring out.
@navidshaikh
Tag plugin tests as !serving and !eventing
2b48afc
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2020
@navidshaikh
Copy link
Collaborator Author

/hold

added a test commit which creates kne2etests0, to verify the functionality

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@navidshaikh
Copy link
Collaborator Author

kne2etests0 namespace was created before e2e started and it was skipped for e2e. ref: log
reverting the test commit
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@navidshaikh navidshaikh added this to the v0.15.0 milestone May 13, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2020
@navidshaikh
Copy link
Collaborator Author

cc: @dsimansk

@dsimansk
Copy link
Contributor

Thanks!
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@knative-prow-robot knative-prow-robot merged commit 20e1a79 into knative:master May 14, 2020
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
d88920a 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
@rhuss rhuss mentioned this pull request Mar 9, 2021
Merged
4 tasks
rhuss added a commit to rhuss/knative-client that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver
f266fca 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
knative-prow-robot pushed a commit that referenced this pull request Mar 9, 2021
@rhuss
Add David as approver (#1255)
9fa8d6b 
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * #1246
  * #1194
  * #738
  * #832
  * #1016
  * #877
  * #667
  * #697
  * #1212
  * #835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
mgencur pushed a commit to openshift-knative/client that referenced this pull request Nov 21, 2022
@dsimansk
[release-v0.25.1] Remove python http server from artifact image (knat…
9a20bb4 
…ive#835)

* [release-v0.25.1] Remove python http server from artifact image

* Fix duplicate package install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@navidshaikh @knative-prow-robot @dsimansk @googlebot