Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to Knative serving/eventing 0.14.0 #810

Merged
merged 4 commits into from
Apr 16, 2020
Merged

chore: Update to Knative serving/eventing 0.14.0 #810

merged 4 commits into from
Apr 16, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Apr 16, 2020

and also move ApiServerSource to v1alpha2, adapting the option
(from "controller" to "labelSelector")

@rhuss
chore: Update to Knative serving/eventing 0.14.0
1d4c5d2 
and also move ApiServerSource to v1alpha2, adapting the option
(from "controller" to "labelSelector")
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 16, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 16, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/dynamic/client.go 89.2% 86.5% -2.7
pkg/kn/commands/source/apiserver/apiserver.go 62.5% 59.1% -3.4
pkg/kn/commands/source/apiserver/describe.go 84.3% 82.7% -1.6
pkg/kn/commands/source/apiserver/flags.go 75.5% 70.0% -5.5
pkg/sources/v1alpha2/apiserver_client.go Do not exist 93.2%
pkg/sources/v1alpha2/apiserver_client_mock.go Do not exist 77.3%
pkg/sources/v1alpha2/ping_client.go 91.7% 91.4% -0.2

maximilien
maximilien approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit df92787 into knative:master Apr 16, 2020
@navidshaikh navidshaikh added this to the v0.14.0 milestone Apr 20, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@steuhs @knative-prow-robot
monitoring config validator (knative#820)
685d32d 
* monitoring config validator

validate config yaml contains valid patterns for all error message
patterns and job name patterns.

This completes the validation part of knative#810. A separate PR will be
responsible for setting the defaults

* address Srinivas' comments

* address one more Sri's comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rhuss @knative-metrics-robot @knative-prow-robot @maximilien @navidshaikh @googlebot