Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wait, no-wait and async flags per bool var CLI convention #802

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Make wait, no-wait and async flags per bool var CLI convention #802

merged 4 commits into from
Apr 14, 2020

Commits on Apr 14, 2020

  1. Make wait, no-wait and async flags per bool var CLI convention 

     Fixes knative#800

 - Deprecated bool vars can be supported for CLI convention
 - Bind --async flag value to --no-wait
 - Only one flag among [wait, no-wait, async] can be provided, else raise an error
    @navidshaikh
    navidshaikh committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    b8417a3 View commit details
    Browse the repository at this point in the history

  2. Simplify conditionals

    @navidshaikh
    navidshaikh committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    064a02f View commit details
    Browse the repository at this point in the history

  3. Add unit tests for deprecated flag async

    @navidshaikh
    navidshaikh committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    b79ddce View commit details
    Browse the repository at this point in the history

  4. Fix a typo

    @navidshaikh
    navidshaikh committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    4e845cd View commit details
    Browse the repository at this point in the history