Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trigger): add --inject-broker flag to trigger create command #726

Merged
merged 5 commits into from
Mar 10, 2020
Merged

feat(trigger): add --inject-broker flag to trigger create command #726

merged 5 commits into from
Mar 10, 2020

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Mar 10, 2020 •
edited
Loading

Description

Allow user to add default broker when creating trigger.

Changes

  • Add flag --inject-broker to trigger create commnad

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2020
@dsimansk dsimansk changed the title WIP: feat(trigger): annotate trigger to inject default broker feat(trigger): annotate trigger to inject default broker Mar 10, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2020
@dsimansk dsimansk changed the title feat(trigger): annotate trigger to inject default broker feat(trigger): add --inject-broker flag to trigger create command Mar 10, 2020
rhuss
rhuss requested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I would the the builder differently. see inline.

pkg/eventing/v1alpha1/client.go Outdated Show resolved Hide resolved
pkg/eventing/v1alpha1/client.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/v1alpha1/client.go 81.5% 83.1% 1.6
pkg/kn/commands/trigger/create.go 81.2% 83.3% 2.1

rhuss
rhuss approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@knative-prow-robot knative-prow-robot merged commit 8dbf439 into knative:master Mar 10, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@srinivashegde86 @knative-prow-robot
Reuse the junit lib to generate junit xml for coverage results (knati…
939e3cc 
…ve#726)

* Reuse the junit lib to generate junit xml for coverage results

* Use AddTestCase instead of appending slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsimansk @knative-metrics-robot @knative-prow-robot @rhuss @googlebot