Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wait): Only use MODIFIED events when waiting for Read == True #701

Merged
merged 1 commit into from
Mar 4, 2020
Merged

fix(wait): Only use MODIFIED events when waiting for Read == True #701

merged 1 commit into from
Mar 4, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Mar 4, 2020

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 4, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/wait/wait_for_ready.go 77.6% 77.9% 0.2

maximilien
maximilien approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 50a36b4 into knative:master Mar 4, 2020
@dsimansk dsimansk mentioned this pull request Mar 5, 2020
Closed
@rhuss rhuss mentioned this pull request Apr 28, 2020
Closed
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@srinivashegde86 @knative-prow-robot
Add ability to add cpu and memory profile with loadgenerator (knative…
1d713f0 
…#701)

* Add ability to add cpu and memory profile with loadgenerator

* Store profiles in artifacts dir

* Pass the filename to results

* Fail test when err happens
dsimansk pushed a commit to dsimansk/client that referenced this pull request May 12, 2021
@mgencur
Use fully qualified image references in Tekton tests (knative#701)
7b46654
dsimansk pushed a commit to dsimansk/client that referenced this pull request Jun 16, 2021
@mgencur @dsimansk
Use fully qualified image references in Tekton tests (knative#701)
09e663f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhuss @knative-metrics-robot @knative-prow-robot @maximilien @googlebot