fix(help): initialize default help cmd early #664
Conversation
There was a problem hiding this comment.
@dsimansk: 0 warnings.
In response to this:
The default behaviour of Cobra library is to add default
helpcmd as late as possible to allow modifications. However, in case ofkninitialization of help is superseded by plugin parsing and fails withunknown commanderror.➜ client git:(issue-533) kn help Error: unknown command 'help' Run 'kn --help' for usage.This changes brings back
helpas a command and enables usage of bothkn helpandkn help <sub-command>.Proposed Changes
- Add early initialization of default help command.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/XS
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/retest |
The default behaviour of Cobra library is to add default
helpcmd as late as possible to allow modifications. However, in case ofkninitialization of help is superseded by plugin parsing and fails withunknown commanderror.This change brings back
helpas a command and enables usage of bothkn helpandkn help <sub-command>.Proposed Changes