Add support for command and args in service create

[dsimansk]

Fixes #604

Proposed Changes

• Add new flags --cmd and --arg
• --cmd accepts a single string input
• --arg can be used multiple times to provide as many as neeed
• Examples:
  • --cmd /app/start
  • --cmd /app/start --arg myArg
  • --arg myArg1 --arg --myArg2 --arg myArg3=3.

Even though podSpec.Command accepts stringArray and arguments can be passed directly to this field. Per discussion on #604 I've decided to follow more verbose and strict approach to make a clear distinction to improve usability and user-exp.

/assign @rhuss
/assign @navidshaikh

[knative-prow-robot]

@dsimansk: 0 warnings.

In response to this:

Fixes #604

Proposed Changes

• Add new flags --cmd and --arg
• --cmd accepts a single string input
• --arg can be used multiple times to provide as many as neeed
• Examples:
• --cmd /app/start
• --cmd /app/start --arg myArg
• --arg myArg1 --arg --myArg2 --arg myArg3=3.

Even though podSpec.Command accepts stringArray and arguments can be passed directly to this field. Per discussion on #604 I've decided to follow more verbose and strict approach to make a clear distinction to improve usability and user-exp.

/assign @rhuss
/assign @navidshaikh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Welcome @dsimansk! It looks like this is your first PR to knative/client 🎉

[knative-prow-robot]

Hi @dsimansk. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[navidshaikh]

/ok-to-test

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	82.3%	82.4%	0.1
pkg/serving/config_changes.go	79.8%	79.8%	0.0

[rhuss]

Thanks ! Looks good to me.

Maybe you could add some E2E tests in an additional PR ? (like the other e2e tests that you find in the test/ directory.

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment