Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor serving v0.11.0 and run tests against it #545

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Vendor serving v0.11.0 and run tests against it #545

merged 2 commits into from
Dec 11, 2019

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Dec 10, 2019 •
edited
Loading

Proposed Changes

  • Run tests against serving v0.11.0
  • Vendor serving v0.11.0

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 10, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2019
maximilien
maximilien reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@navidshaikh
Copy link
Collaborator Author

/test pull-knative-client-integration-tests-latest-release

    --- FAIL: TestTrafficSplit/revert_all_traffic_to_latest_ready_revision_of_service (11.70s)

@knative-prow-robot knative-prow-robot merged commit 4f0eb99 into knative:master Dec 11, 2019
@navidshaikh navidshaikh deleted the pr/serving-0.11 branch December 11, 2019 05:32
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@yt3liu @knative-prow-robot
Enable the verify-owners plugin for Prow (knative#324) (knative#545)
304c7c6
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Dec 18, 2020
@dsimansk
Disable s390x build (knative#545)
1241c4f 
* Disable s390x build

* Try base image from internal registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navidshaikh @knative-prow-robot @maximilien @googlebot