Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple NAMEs on service delete #492

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Support multiple NAMEs on service delete #492

merged 2 commits into from
Nov 12, 2019

Conversation

daisy-ycguo
Copy link
Member

@daisy-ycguo daisy-ycguo commented Nov 11, 2019 •
edited
Loading

Partially address #317

Proposed Changes

  • Support multiple NAMEs on kn service delete

Release Note:

In the following cases, add a short description of PR to the unreleased section in CHANGELOG.adoc:

  • 🧽 Support multiple NAMEs on kn service delete

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2019
@daisy-ycguo
Copy link
Member Author

/retest

1 similar comment
@rhuss
Copy link
Contributor

rhuss commented Nov 11, 2019

/retest

@rhuss
Copy link
Contributor

rhuss commented Nov 11, 2019

@daisy-ycguo please rebase on master, this should fix the test issues.

rhuss
rhuss requested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, please also add a line to CHANGELOG.adoc for this change. thanks !

maximilien
maximilien suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need an e2e test for this.

What happens if the list has bogus services in it. Should the whole command fail or continue. Likely fail as you have implemented but a message to user that the remaining services did not get deleted is likely needed.

Let's be clear about the failure scenarios and add appropriate tests.

Thanks for the contribution.

@maximilien
Copy link
Contributor

/retest

@daisy-ycguo daisy-ycguo force-pushed the multiple branch 7 times, most recently from a4e4ba7 to bee8514 Compare November 12, 2019 09:13
@daisy-ycguo
Copy link
Member Author

Thank you for review. Your comment is addressed. An e2e test case is added.

We definitely need an e2e test for this.

What happens if the list has bogus services in it. Should the whole command fail or continue. Likely fail as you have implemented but a message to user that the remaining services did not get deleted is likely needed.

Let's be clear about the failure scenarios and add appropriate tests.

Thanks for the contribution.

@daisy-ycguo
Copy link
Member Author

looks good to me, please also add a line to CHANGELOG.adoc for this change. thanks !

Thank you for review. I've add a line to CHANGELOG.adoc.

@rhuss
Copy link
Contributor

rhuss commented Nov 12, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@rhuss
Copy link
Contributor

rhuss commented Nov 12, 2019

/approved

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/delete.go 75.0% 76.5% 1.5

rhuss
rhuss approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@knative-prow-robot knative-prow-robot merged commit 5fc8197 into knative:master Nov 12, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Updates to the Prow config generator (knative#492)
c579616 
* Updates to the Prow config generator

* move account presets to the jobs, making them self-contained
* allow filtering config by job name
* allow adding a wrapper command to a job

* Remove redundant filter check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien requested changes

@rhuss rhuss rhuss approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daisy-ycguo @rhuss @maximilien @knative-metrics-robot @knative-prow-robot @googlebot