removes remaining references to 'lookup-plugins-in-path' #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
|
/ok-to-test |
knative-prow-robot
added
the
ok-to-test
rhuss
reviewed
Nov 11, 2019
| @@ -90,7 +90,7 @@ func TestPluginHandler(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("when plugin is in $PATH", func(t *testing.T) { | |||
| t.Run("--lookup-plugins-in-path=true", func(t *testing.T) { | |||
| t.Run("--lookup-plugins=true", func(t *testing.T) { | |||
There was a problem hiding this comment.
Isn't it that we now have --lookup-plugins and --no-lookup-plugins for boolean params ?
rhuss
approved these changes
Nov 11, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* Remove usage of K8S_CLUSTER_OVERRIDE 1. It was removed in knative#481. 1. This is a dupe of a flag in pkg/test/e2e_flags.go, we should have a single approach for such helpers. * Remove unused import
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Oct 9, 2020
* Update SPEC file for release v0.17.1 * fix(ci): Pin CI setup to 0.17.x versions * fix(ci): Remove unecessary replace of Eventing imgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes remaining references to 'lookup-plugins-in-path' which is now renamed to the simpler 'lookup-plugins'
Proposed Changes