Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendors serving v0.9.0 #458

Merged
merged 5 commits into from
Oct 28, 2019
Merged

Vendors serving v0.9.0 #458

merged 5 commits into from
Oct 28, 2019

Conversation

navidshaikh
Copy link
Collaborator

/lint

Proposed Changes

  • Vendors serving v0.9.0
  • Updates code and tests to refer the required data structure and method/function calls
  • duckv1beta1 -> duckv1 conditions
  • traffic percent value is now *int64
  • containerConcurrency validation method relocation

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2019
knative-prow-robot
knative-prow-robot reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 1 warning.

In response to this:

/lint

Proposed Changes

  • Vendors serving v0.9.0
  • Updates code and tests to refer the required data structure and method/function calls
  • duckv1beta1 -> duckv1 conditions
  • traffic percent value is now *int64
  • containerConcurrency validation method relocation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/human_readable_flags.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@navidshaikh
Copy link
Collaborator Author

/lint

knative-prow-robot
knative-prow-robot reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhuss
Copy link
Contributor

rhuss commented Oct 25, 2019

@navidshaikh the integration test failures seem to be legit, so you might want to have a look ?

@navidshaikh
Copy link
Collaborator Author

navidshaikh commented Oct 25, 2019 •
edited
Loading

@rhuss : Yes, looking at it, apparently I introduced a bug in RemoveNullTargets method and we are seeing the difference in actual vs expected targets. Fixing it..

@navidshaikh
Vendors serving v0.9.0
1d6e6cf
@navidshaikh
Updates references per serving v0.9.0 vendoring
54b070e 
 - Updates code and tests to refer the required data structure and method/function calls
 - duckv1beta1 -> duckv1 conditions
 - traffic percent value is now *int64
 - containerConcurrency validation method relocation
@navidshaikh
fix(golint): exported function should have comment
1a2f0f9 
 for NonReadyConditionReason function
@navidshaikh
Updates check for removing null targets
bc08d1b 
 fixes the pointer value check
toVersus
toVersus reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@toVersus toVersus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit comments only :)

pkg/serving/config_changes.go Outdated Show resolved Hide resolved
pkg/serving/config_changes_test.go Outdated Show resolved Hide resolved
pkg/serving/config_changes_test.go Outdated Show resolved Hide resolved
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/describe.go 84.8% 84.7% -0.0
pkg/serving/config_changes.go 82.4% 82.3% -0.1

@navidshaikh
Copy link
Collaborator Author

/retest

@sixolet
Copy link
Contributor

sixolet commented Oct 28, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@knative-prow-robot knative-prow-robot merged commit a32f566 into knative:master Oct 28, 2019
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 8, 2020
@dsimansk
chore: Add grpc-ping test image (knative#458)
746cb0f
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 2, 2024
@dsimansk
[release-v1.14] Update func to latest midstream (knative#458)
7b541f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toVersus toVersus toVersus left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@sixolet sixolet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@navidshaikh @knative-prow-robot @rhuss @knative-metrics-robot @sixolet @toVersus @googlebot