Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build.sh) Add indicator in watch mode after successful compilation #432

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Oct 8, 2019

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2019
@rhuss
Copy link
Contributor Author

rhuss commented Oct 8, 2019

@navidshaikh a quick one, helps in build.sh -w to see when compilation finished.

Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-knative-client-integration-tests
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e67d207 into knative:master Oct 8, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request Oct 8, 2019
…ion (knative#432)

* chore(build.sh) Add indicator in watch mode after successful compilation

* chore(build): Update changelog
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
dsimansk added a commit to dsimansk/client that referenced this pull request Sep 12, 2024
* [release-v1.14] Add func v1.15

* Fix default util image and func patch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants