Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn version command to list supported serving versions and APIs #370

Merged
merged 1 commit into from
Aug 19, 2019
Merged

kn version command to list supported serving versions and APIs #370

merged 1 commit into from
Aug 19, 2019

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Aug 16, 2019 •
edited
Loading

/lint

Fixes #369

Proposed Changes

  • Replace Dependencies: with Support:
  • Add list of supported Serving versions kn can work with
  • Add list of supported Serving APIs kn can work with
✗ ./kn version
Version:      v20190816-local-e36089f-dirty
Build Date:   2019-08-16 13:08:26
Git Revision: e36089f
Support:
- Serving: v0.8.0  v0.7.1
- API(s):  v1alpha1

Release notes

kn version command shows supported Serving and API versions

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 16, 2019
knative-prow-robot
knative-prow-robot reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 1 warning.

In response to this:

/lint

Fixes #369

Proposed Changes

  • Replace Dependencies: with Support:
  • Add list of supported Serving versions kn can work with
  • Add list of supported Serving APIs kn can work with
✗ ./kn version
Version:      v20190816-local-e36089f-dirty
Build Date:   2019-08-16 13:08:26
Git Revision: e36089f
Support:
- Serving: v0.8.0  v0.7.1
- API(s):  v1alpha1


kn version command shows supported Serving and API versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/version.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2019
@navidshaikh
kn version command to list supported serving versions and APIs
12c5f33 
 Fixes knative#369

 - Replace `Dependencies:` with `Support:`
 - Add list of supported Serving versions kn can work with
 - Add list of supported Serving APIs kn can work with

 ```
 ✗ ./kn version
Version:      v20190816-local-e36089f-dirty
Build Date:   2019-08-16 13:08:26
Git Revision: e36089f
Support:
- Serving: v0.8.0  v0.7.1
- API(s):  v1alpha1

 ```
@navidshaikh
Copy link
Collaborator Author

/lint

knative-prow-robot
knative-prow-robot reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jimcurtis
jimcurtis approved these changes Aug 19, 2019
View reviewed changes
Copy link

@jimcurtis jimcurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This looks good.

maximilien
maximilien approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimcurtis, maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit dccaf36 into knative:master Aug 19, 2019
@navidshaikh navidshaikh deleted the pr/better-dependency-listing branch August 20, 2019 07:12
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Don't fetch all remotes when releasing (knative#370)
816070a 
Instead, only fetch the remote branch we're interested in.
dsimansk added a commit to dsimansk/client that referenced this pull request Mar 11, 2024
@dsimansk
[release-1.11] Update func build images (knative#370)
8044fc7 
* [release-1.11] Update func build images

* Remove mininal image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@maximilien maximilien maximilien approved these changes

@jimcurtis jimcurtis jimcurtis approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command 'kn version' to print supported serving versions it can work with
5 participants
@navidshaikh @knative-prow-robot @maximilien @jimcurtis @googlebot