List services sorted by alphabetical order

[daisy-ycguo]

Fixes #324

Proposed Changes

• kn service list lists services sorted by alphabetical order.

[navidshaikh]

/test pull-knative-client-integration-tests-latest-release

[navidshaikh]

@daisy-ycguo : I think the service list we receive from server comes sorted by name already, check #324 (comment)

[navidshaikh]

@daisy-ycguo : I think we could instead update this PR to ensure (by adding unit tests) that the list printed is sorted.

[navidshaikh]

I think we could instead update this PR to ensure (by adding unit tests) that the list printed is sorted.

@daisy-ycguo : Ignore this comment as mentioned on the issue that other implementation might not return the sorted service list.

[navidshaikh]

/lint

[knative-prow-robot]

@navidshaikh: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

The integration test flake

Failed to successfully execute 'kn service create hello --image gcr.io/knative-samples/helloworld-go -n kne2etests1': Execution error: stderr: 'RevisionFailed: Revision "hello-l58wg" failed with message: Unable to fetch image "gcr.io/knative-samples/helloworld-go": serviceaccounts "default" not found.

is really annoying. 'hope we get that fixed but no idea how (see #329 for tracking this). Seems that it happens more often recently.

[rhuss]

/retest

[rhuss]

/retest

[navidshaikh]

@daisy-ycguo : Thanks! Please update the CHANGELOG.

[daisy-ycguo]

@daisy-ycguo : Thanks! Please update the CHANGELOG.

I did. Thanks for the instruction.

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/service_list.go	86.7%	87.5%	0.8

[rhuss]

thanks !

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment