Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document boolean flags by explicit value #284

Closed
wants to merge 1 commit into from
Closed

Document boolean flags by explicit value #284

wants to merge 1 commit into from

Conversation

sixolet
Copy link
Contributor

@sixolet sixolet commented Jul 21, 2019

Documents boolean flags as specified by boolean value on the command line.

Mutually exclusive with #283

Vote by thumbs up reaction emoji. Winner gets merged.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 21, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2019
@sixolet sixolet added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2019
@sixolet sixolet mentioned this pull request Jul 21, 2019
Merged
@rhuss
Copy link
Contributor

rhuss commented Jul 22, 2019

See my reasoning why I'm not in favor of a kn --help=true kind of handling in https://github.com/knative/client/pull/283/files#r305722369

@cppforlife cppforlife mentioned this pull request Jul 22, 2019
Merged
@rhuss rhuss mentioned this pull request Jul 22, 2019
Merged
@sixolet
Copy link
Contributor Author

sixolet commented Jul 27, 2019

This is the loser by votes, so closing.

@sixolet sixolet closed this Jul 27, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Fix wait_until_object_does_not_exist() (knative#284)
0bf7d2a 
The function is currently checking the opposite, thus it times out most of the time.

Bonus: fix error message.
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 17, 2023
@dsimansk
Update x/net lib to latest version (knative#284)
a830fd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sixolet @knative-prow-robot @rhuss @googlebot