Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate scale and container concurrency options when updating configuration resource #279

Merged
merged 12 commits into from
Jul 25, 2019
Merged

Validate scale and container concurrency options when updating configuration resource #279

merged 12 commits into from
Jul 25, 2019

Commits on Jul 24, 2019

  1. Validate invalid container concurrency options

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    3254aa9 View commit details
    Browse the repository at this point in the history

  2. Use assert package

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    43356fe View commit details
    Browse the repository at this point in the history

  3. Use FlagSet.Changed and don't care about default values

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    0baea3d View commit details
    Browse the repository at this point in the history

  4. Update dependency

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    0c9b52f View commit details
    Browse the repository at this point in the history

  5. Follow e2e test changes

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    c7f1b99 View commit details
    Browse the repository at this point in the history

  6. Return error if invalid value is specified by users

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    ca425cf View commit details
    Browse the repository at this point in the history

  7. Fix broken e2e test

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    91df732 View commit details
    Browse the repository at this point in the history

  8. Add more unit tests

    @toVersus
    toVersus committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    010db91 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Fix error message

    @toVersus
    toVersus committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    6010f77 View commit details
    Browse the repository at this point in the history

  2. Fix comment statement

    @toVersus
    toVersus committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    daacda9 View commit details
    Browse the repository at this point in the history

  3. Revert back unrelated changes

    @toVersus
    toVersus committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    08ae326 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @toVersus
    toVersus committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    c81ce8a View commit details
    Browse the repository at this point in the history