Rename lemonade-aware accessors to be less like methods that get from the server #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
Older git versions don't have --exclude, so we match an empty tag. Bonuses: * ensure we have a non empty commit for tags. * show git version on presubmit tests.
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Oct 6, 2023
* [release-v1.10] Add func v1.11.1 * Update vendor dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the method on client were named like
GetRevisionand these accessor methods were named likeGetRevisionTemplate.I was writing some code that mixed both kinds of methods, and it was getting confusing. So this renames the accessors to look different, so I can tell what I'm doing when I'm writing code that uses both.