Clean up e2e test assertion

[toVersus]

This is a follow-up PR of #256 . We should use assert package (and utils) for testing the output string to keep consistency between unit and e2e tests.

[knative-prow-robot]

Hi @toVersus. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

Thanks ! Looks good with one comment below.

The other thing which might be super useful is (now that you removed many error messages when an error is returned, which makes the code easier to read):

In the single main test method, can we wrap the calls to the subtests into t.Run("description of subtest", func(t *testing.T) { .... }) kind of subtest calls. This would make it much easier to spot the error location in case of an error.

Check e.g. client_test.go for how such subtest can be structured.

[rhuss]

/okt-to-test

[toVersus]

In the single main test method, can we wrap the calls to the subtests into t.Run("description of subtest", func(t *testing.T) { .... }) kind of subtest calls.

@rhuss Can I make sure your intention here? Just wrap the subtests in the single main test method (e.g. TestBasicWorkflow) at this level of granularity?

func TestBasicWorkflow(t *testing.T) {
	teardown := Setup(t)
	defer teardown(t)

	t.Run("returns no service before running tests", func(t *testing.T) {
		testServiceListEmpty(t, k)
	})

	t.Run("create hello service and returns no error", func(t *testing.T) {
		testServiceCreate(t, k, "hello")
	}

	t.Run("returns rough and detailed information about hello service")
		testServiceList(t, k, "hello")
		testServiceDescribe(t, k, "hello")
	})
...
}

[toVersus]

@rhuss Thanks for reviewing! I tried to add subtests in main test methods. Let me know if you have any opinions about the level of granularity. BTW, Prow doesn't trigger the test due to a typo 😼

[rhuss]

/ok-to-test

[rhuss]

Thanks !

/lgtm

[navidshaikh]

/test pull-knative-client-integration-tests

[navidshaikh]

/test pull-knative-client-integration-tests-latest-release

[navidshaikh]

Thanks!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss, toVersus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment