feat(build.sh) - Add mandatory license check #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
We could decide to make that optional, too, if this is coming into the way.
maximilien
reviewed
Jun 14, 2019
| @@ -61,7 +61,10 @@ run() { | |||
| # Format source code | |||
| go_fmt | |||
There was a problem hiding this comment.
Minor point...
BTW, should we move go_fmt before compile and test? I hate the idea of the compiled and tested code being changed after.
There was a problem hiding this comment.
Good catch. We can do this, and as the --fast mode skips formatting anyway it doesn't matter whether it is skipped before or after compile ;-)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cppforlife, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
maximilien
pushed a commit
to maximilien/client
that referenced
this pull request
Jun 17, 2019
We could decide to make that optional, too, if this is coming into the way.
maximilien
added a commit
to maximilien/client
that referenced
this pull request
Jun 17, 2019
Implements Kn plugins re-using some code from kubectl plugins. This is WIP to allow concrete discussions and testing and hopefully also allow sub tasks to be created and worked on in parallel. This version contains the following: 1. wraps the main root Kn command to support plugin 2. plugins are any executable in PATH with name kn-* 3. 'kn plugins list' to list found kn plugins 4. skips any kn plugins found with name that match core commands, e.g., kn-service would be ignored 5. execute any valid kn plugins found And is missing: 1. unit and integration tests 2. plugin install command 3. plugin repository command 4. plugin / Knative server version negotiation 5. anything else we agree on in plugin req doc Adds a Golang version of e2e Basic workflow that can execute locally (knative#121) 1. creates a namespace 'kne2etests' (default name, change with env KN_E2E_NAMESPACE) 2. executes kn commands as per Basic workflow doc in said namespace 3. verifies each command's output 4. deletes the 'kne2etests' namespace Fix typo in README.md (knative#181) Renames service 'get' to 'list' (knative#179) * Renames service 'get' to 'list' As per title. * Renames get references to list in e2e tests * Replaces get to list in docs Renames revision 'get' to 'list' (knative#180) * Renames revision 'get' to 'list' As per title. * Renames revision get references to revision list in docs feat(build.sh) - Add mandatory license check (knative#187) We could decide to make that optional, too, if this is coming into the way. Chore: Fix typos in docs (knative#178) fix(service update): Print success message after successful update (knative#169) * fix(service update): Print success message after successful update * chore(service update): Improve test, revert unneeded changes [WIP] Kn plugins implementation Implements Kn plugins re-using some code from kubectl plugins. This is WIP to allow concrete discussions and testing and hopefully also allow sub tasks to be created and worked on in parallel. This version contains the following: 1. wraps the main root Kn command to support plugin 2. plugins are any executable in PATH with name kn-* 3. 'kn plugins list' to list found kn plugins 4. skips any kn plugins found with name that match core commands, e.g., kn-service would be ignored 5. execute any valid kn plugins found 6. started adding UTs for plugin commands and files 7. rebased with latest HEAD And is missing: 1. integration tests 2. plugin install command 3. plugin repository command 4. plugin / Knative server version negotiation 5. anything else we agree on in plugin req doc
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Jul 3, 2023
* [release-v1.9] Add correct version of workflow-plugin * Update vendor dir * Fix strange unit tests init fail * Update workflow-plugin quarkus & dev image LD flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could decide to make that optional, too, if this is coming into the way.