Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added completion for revision resource #1560

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jan 6, 2022

Description

Added completion function to revision describe and delete subcommands

Changes

  • Added function for revision name completion
  • Added unit tests for above

Reference

Fixes #1373

Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Added completion function to revision describe and delete subcommands

Changes

  • Added function for revision name completion
  • Added unit tests for above

Reference

Fixes #1373

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1560 (84c7a4f) into main (c6997da) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   79.59%   79.61%   +0.01%     
==========================================
  Files         163      163              
  Lines        8562     8580      +18     
==========================================
+ Hits         6815     6831      +16     
- Misses       1069     1070       +1     
- Partials      678      679       +1     
Impacted Files Coverage Δ
pkg/kn/commands/completion_helper.go 90.36% <87.50%> (-0.69%) ⬇️
pkg/kn/commands/revision/delete.go 84.12% <100.00%> (+0.25%) ⬆️
pkg/kn/commands/revision/describe.go 51.80% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6997da...84c7a4f. Read the comment docs.

@dsimansk
Copy link
Contributor

@vyasgun can you please rebase? IMO it looks good, we can one by one, since there's going to be conflict in completion_helper.go for the rest of PRs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/completion_helper.go 95.5% 95.2% -0.3

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@knative-prow-robot knative-prow-robot merged commit c5dfb08 into knative:main Jan 10, 2022
@dsimansk dsimansk mentioned this pull request Jan 11, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context sensitive Bash completion
4 participants