Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed panic in kn service describe #1529

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Fixed panic in kn service describe #1529

merged 3 commits into from
Nov 23, 2021

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Nov 23, 2021

Description

Fixed panic during kn service describe

Changes

  • Added length check to prevent panic

Reference

Fixes #1528

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 23, 2021
knative-prow-robot
knative-prow-robot reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Fixed panic during kn service describe

Changes

  • Added length check to prevent panic

Reference

Fixes #1528

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #1529 (86b62a9) into main (76299ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   79.38%   79.39%           
=======================================
  Files         162      162           
  Lines        8494     8497    +3     
=======================================
+ Hits         6743     6746    +3     
  Misses       1073     1073           
  Partials      678      678
Impacted Files Coverage Δ
pkg/kn/commands/revision/describe.go 51.51% <100.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76299ef...86b62a9. Read the comment docs.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2021
dsimansk
dsimansk reviewed Nov 23, 2021
View reviewed changes
CHANGELOG.adoc Outdated Show resolved Hide resolved
dsimansk
dsimansk requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit in changelog, otherwise LGTM.

@vyasgun @dsimansk
Update CHANGELOG.adoc
86b62a9 
Co-authored-by: David Simansky <[email protected]>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/revision/describe.go 64.4% 65.0% 0.7

dsimansk
dsimansk approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@knative-prow-robot knative-prow-robot merged commit 4316d03 into knative:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@dsimansk dsimansk dsimansk approved these changes

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic during kn service describe when a revision has ContainerMissing
4 participants
@vyasgun @knative-metrics-robot @knative-prow-robot @dsimansk