Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookup-plugins flag #1506

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Nov 2, 2021

Description

Remove deprecated plugin lookup flag

Changes

  • Removed instances of --lookup-plugins

Reference

Fixes #1491

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 2, 2021
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 0 warnings.

In response to this:

Description

Remove deprecated plugin lookup flag

Changes

  • Removed instances of --lookup-plugins

Reference

Fixes #1491

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2021
@dsimansk
Copy link
Contributor

dsimansk commented Nov 2, 2021

@vyasgun fyi integration tests will fail until PR #1505 is merged.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1506 (2933ea2) into main (c1e3589) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   79.34%   79.38%   +0.03%     
==========================================
  Files         162      162              
  Lines        8502     8494       -8     
==========================================
- Hits         6746     6743       -3     
+ Misses       1075     1073       -2     
+ Partials      681      678       -3     
Impacted Files Coverage Δ
pkg/kn/config/config.go 54.25% <100.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e3589...2933ea2. Read the comment docs.

@rhuss
Copy link
Contributor

rhuss commented Nov 2, 2021

/retest

@rhuss
Copy link
Contributor

rhuss commented Nov 2, 2021

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@dsimansk
Copy link
Contributor

dsimansk commented Nov 2, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/config/config.go 72.3% 72.4% 0.1

@vyasgun
Copy link
Contributor Author

vyasgun commented Nov 2, 2021

/retest

@knative-prow-robot knative-prow-robot merged commit da6f164 into knative:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated flags before 1.0 release
5 participants