Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --autoscale-window to --scale-window #1489

Merged
merged 5 commits into from
Oct 26, 2021

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Oct 21, 2021

and deprecate --autoscale-window

and deprecate `--autoscale-window`
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 21, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1489 (1d85374) into main (534d913) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   79.10%   79.15%   +0.05%     
==========================================
  Files         162      162              
  Lines        8443     8445       +2     
==========================================
+ Hits         6679     6685       +6     
+ Misses       1080     1077       -3     
+ Partials      684      683       -1     
Impacted Files Coverage Δ
...kg/kn/commands/service/configuration_edit_flags.go 79.75% <100.00%> (+1.83%) ⬆️
pkg/serving/config_changes.go 89.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534d913...1d85374. Read the comment docs.

Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs haven't been regenerated or included in the commit.

@rhuss
Copy link
Contributor Author

rhuss commented Oct 25, 2021

/retest

@dsimansk
Copy link
Contributor

/retest

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/configuration_edit_flags.go 85.2% 86.8% 1.6

@rhuss
Copy link
Contributor Author

rhuss commented Oct 26, 2021

@max @dsimansk ptal, tests are green now.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 03045c8 into knative:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants