Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecatedImageDigest field #1454

Merged

Conversation

dsimansk
Copy link
Contributor

Description

Note to the reviewers: I'll open new issue to handle multi-container Revisions. Hence the PR uses only ContainerStatus[0] that should be equal to DeprecatedImageDigest by the following:

// If multiple containers specified then DeprecatedImageDigest holds the digest
// for serving container.

https://github.com/knative/serving/blob/d2461492bea18cde5f9aa0419c8fee24570782aa/pkg/apis/serving/v1/revision_types.go#L139-L151

Changes

  • 🐣 Remove DeprecatedImageDigest field

Reference

Fixes failing auto update PR #1452.

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #1454 (35a9de7) into main (82a21a5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files         162      162           
  Lines        8416     8416           
=======================================
  Hits         6647     6647           
  Misses       1088     1088           
  Partials      681      681           
Impacted Files Coverage Δ
pkg/kn/commands/revision/describe.go 50.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a21a5...35a9de7. Read the comment docs.

@rhuss
Copy link
Contributor

rhuss commented Sep 17, 2021

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@knative-prow-robot knative-prow-robot merged commit 47558c1 into knative:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants