Fix issue with Windows pathes not being escaped when applying a regexp. #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 160 160
Lines 8234 8234
=======================================
Hits 6433 6433
Misses 1107 1107
Partials 694 694
Continue to review full report at Codecov.
|
dsimansk
reviewed
Jul 21, 2021
| @@ -335,6 +335,15 @@ func TestRunWithExit(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestExtractCommandPathFromErrorMessage(t *testing.T) { | |||
|
Thanks! Looks good to me. @rhuss fancy adding changelog entry for the fix? |
maximilien
approved these changes
Jul 21, 2021
knative-prow-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There have been issues when a full Windows path has been inserted literally to create a regexp, since the backslashes used as path separators are confusing the regexp engine. This fix will quote any input coming from the outside.