Adding base64 data handling to ping update command

[vyasgun]

Description

Adding base64 data handling to ping update command. Handling comments from #1388

Changes

• Adding a test case to test builder functions
• Handling base64 data in update command
• Modified usage/error strings for more clarity

Reference

Fixes #1204

[knative-prow-robot]

@vyasgun: 0 warnings.

In response to this:

Description

Adding base64 data handling to ping update command. Handling comments from #1388

Changes

• Adding a test case to test builder functions
• Handling base64 data in update command
• Modified usage/error strings for more clarity

Reference

Fixes #1204

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1392 (e906663) into main (2164243) will increase coverage by 1.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
+ Coverage   76.51%   78.23%   +1.71%     
==========================================
  Files         160      160              
  Lines        8234     8246      +12     
==========================================
+ Hits         6300     6451     +151     
+ Misses       1229     1104     -125     
+ Partials      705      691      -14     

Impacted Files	Coverage Δ
pkg/kn/commands/source/ping/create.go	82.60% <100.00%> (-3.36%)	⬇️
pkg/kn/commands/source/ping/describe.go	75.43% <100.00%> (+1.36%)	⬆️
pkg/kn/commands/source/ping/flags.go	67.81% <100.00%> (+7.25%)	⬆️
pkg/kn/commands/source/ping/update.go	84.90% <100.00%> (+1.23%)	⬆️
pkg/wait/test_wait_helper.go	100.00% <0.00%> (ø)
pkg/wait/wait_for_ready.go	87.71% <0.00%> (+5.26%)	⬆️
pkg/serving/config_changes.go	84.74% <0.00%> (+6.77%)	⬆️
pkg/serving/v1/gitops.go	85.22% <0.00%> (+11.36%)	⬆️
pkg/serving/v1/apply.go	80.32% <0.00%> (+11.47%)	⬆️
pkg/kn/commands/namespaced.go	81.08% <0.00%> (+16.21%)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164243...e906663. Read the comment docs.

[dsimansk]

I'd be great if you could add a few test cases to E2E tests as well. At least asserting no errors on create and binary data in description. Bonus would be asserting sink logs. :)
https://github.com/knative/client/blob/main/test/e2e/ping_test.go#L29

Finally, please add new feature entry to CHANGELOG.adoc file.

[dsimansk]

/lgtm

Not approving yet for others to take a look maybe.

[vyasgun]

/retest

[vyasgun]

/retest

[dsimansk]

Thanks @vyasgun!

So let's go with approve this time, and leave lgtm for others to take a look. :)
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/source/ping/create.go	90.2%	88.2%	-2.0
pkg/kn/commands/source/ping/describe.go	86.8%	87.3%	0.5
pkg/kn/commands/source/ping/flags.go	57.7%	64.5%	6.8
pkg/kn/commands/source/ping/update.go	90.9%	91.5%	0.6

[dsimansk]

@vyasgun thanks again, great job on both related PRs. 👍

/lgtm