Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subscription's Channel to use KRefence type #1326

Merged
merged 1 commit into from
May 25, 2021

Conversation

dsimansk
Copy link
Contributor

Description

Per update on Eventing side, use the correct type in client code.

Changes

  • Fix Subscription's Channel to use KRefence type

Reference

knative/eventing#5412

/cc @knative/client-reviewers

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 24, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #1326 (39aba27) into main (d0327bc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         160      160           
  Lines        8151     8151           
=======================================
  Hits         5948     5948           
  Misses       1476     1476           
  Partials      727      727           
Impacted Files Coverage Δ
pkg/kn/flags/channel_types.go 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0327bc...39aba27. Read the comment docs.

@navidshaikh
Copy link
Collaborator

/assign

Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@knative-prow-robot knative-prow-robot merged commit 0c6ef82 into knative:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants