Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Zsh completion (finishes issue #130) #132

Merged
merged 1 commit into from
May 20, 2019

Conversation

maximilien
Copy link
Contributor

No description provided.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/completion.go 66.7% 57.1% -9.5

@cppforlife
Copy link

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@knative-prow-robot knative-prow-robot merged commit 3189c30 into knative:master May 20, 2019
rhuss pushed a commit to rhuss/knative-client that referenced this pull request May 27, 2019
maximilien added a commit to maximilien/client that referenced this pull request May 28, 2019
@drnic drnic mentioned this pull request Oct 1, 2019
@maximilien maximilien deleted the issue130 branch December 20, 2019 02:18
dsimansk added a commit to dsimansk/client that referenced this pull request Apr 27, 2023
* fix: Check if release branch exists

* Reflect review suggestion

---------

Co-authored-by: David Simansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants