Fix for serviceaccounts "default" not found flaky issue

[pratham-m]

Description

This PR intends to fix serviceaccount "default" not found flaky issue which is a race condition observed on some OCP4.x platforms.

Changes

lib/test/integration.go now waits for default serviceaccount to be ready before returning a new KnTest object when executing e2e tests.

[knative-prow-robot]

@pratham-m: 0 warnings.

In response to this:

Description

This PR intends to fix serviceaccount "default" not found flaky issue which is a race condition observed on some OCP4.x platforms.

Changes

lib/test/integration.go now waits for default serviceaccount to be ready before returning a new KnTest object when executing e2e tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Welcome @pratham-m! It looks like this is your first PR to knative/client 🎉

[knative-prow-robot]

Hi @pratham-m. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pratham-m]

/assign @dsimansk

[dsimansk]

/ok-to-test

[dsimansk]

@pratham-m thanks looks good!

Can you please run ./hack/build.sh -c? There's a formatting issue in the code. Otherwise the integrations tests passed with this change.

[pratham-m]

@dsimansk done with code formatting changes

[dsimansk]

/lgtm

@rhuss @navidshaikh @maximilien PTAL.
This PR should stabilize our test suite on clusters that might have a "slower" namespace initialization, hence the description. Afaik @pratham-m was able to achieve more consistent results with additional check/wait. On the hand it should not affect in any way our CI.

[maximilien]

Only change in test and seems to be OK to me.
/ok-to-test
/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment